Import mapbox-gl built css instead of source css #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import mapbox-gl built css instead of source css. mapbox-gl source css is not valid css because they're using postcss.
|
@maxburs, do you mind trying out react-azure-maps@next for this issue? We've removed the css import (PR) and you'll need to import them manually in your app, please see MIGRATION.md for more details. Thanks. |
|
@yulinscottkang Removing the css import is even better! I've updated to react-azure-maps@next successfully. One note on migrating from 0.0.6 to 1.0.0-beta.0: there doesn't appear to be a commonjs version anymore. If that change was recent, it might be worth calling it out in the MIGRATION.md file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import mapbox-gl built css instead of source css. mapbox-gl source css is not valid css because they're using postcss.
This causes some toolchains to be unable to parse react-azure-maps. For example, here's an error my team is seeing: