-
Notifications
You must be signed in to change notification settings - Fork 10
Ingress Changes #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress Changes #263
Conversation
…espace management
…th dual gateway access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the ingress configuration from legacy Istio VirtualServices to the Gateway API, improving DNS/certificate provisioning, cross-namespace routing with ReferenceGrants, and overall infrastructure flexibility.
- Migrates VirtualService definitions to HTTPRoute and ReferenceGrant resources.
- Updates certificate configuration and DNS annotations to align with Gateway API requirements.
- Revises documentation, Helm chart values, and post-provisioning scripts to support the new configuration model.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| software/applications/web-site/referencegrant.yaml | Adds a ReferenceGrant for cross-namespace HTTPRoute access for the web-site application. |
| software/applications/web-site/ingress.yaml | Replaces the legacy VirtualService with comments referring to the new HTTPRoute resource. |
| software/applications/web-site/httproute.yaml | Introduces an HTTPRoute resource for the web-site application. |
| scripts/post-provision.ps1 | Revises public IP retrieval and DNS annotation to target the new Gateway API service. |
| docs/gateway-migration-summary.md | Documents the migration process and updated configuration details. |
| charts/osdu-developer-service/templates/virtual-service.yaml | Removes legacy VirtualService definitions in favor of Gateway API templates. |
| charts/osdu-developer-service/templates/reference-grant.yaml | Adds a templated ReferenceGrant for the service chart. |
| charts/osdu-developer-service/templates/http-route.yaml | Provides an HTTPRoute template for the developer service with CORS filters. |
| charts/osdu-developer-auth/templates/virtual-service.yaml | Removes legacy VirtualService configuration for authentication services. |
| charts/osdu-developer-auth/templates/reference-grant.yaml | Introduces ReferenceGrant templates for authentication services. |
| charts/osdu-developer-auth/templates/http-route.yaml | Adds an HTTPRoute template for routing to authentication services. |
| charts/istio-ingress/values.yaml | Updates TLS credential names to match Gateway API configurations. |
| charts/istio-ingress/templates/referencegrants.yaml | Provides informational comments on managing ReferenceGrants. |
| charts/istio-ingress/templates/httproutes.yaml | Adds documentation regarding ACME challenge handling with HTTPRoutes. |
| charts/istio-ingress/templates/gateways.yaml | Transitions the Gateway resources to use the Gateway API instead of Istio’s native configuration. |
| charts/istio-ingress/templates/certificate.yaml | Documents the certificate provisioning process triggered by the istio-certs chart. |
| charts/istio-certs/values.yaml | Switches configuration keys from Istio to Gateway API service names. |
| charts/istio-certs/templates/configmap.yaml | Updates service names in bash scripts for DNS annotation and load balancer IP retrieval. |
| charts/istio-certs/templates/access_control.yaml | Adds RBAC permissions for managing Gateway API resources. |
| charts/istio-certs/README.md | Revises the chart documentation to reflect Gateway API integration for DNS and certificate provisioning. |
Comments suppressed due to low confidence (2)
charts/osdu-developer-service/templates/http-route.yaml:11
- It appears that the 'spec' block is written in a single line with 'parentRefs:'. For improved readability and maintainability, please reformat this section so that 'parentRefs:' is placed on a new indented line under 'spec:'.
spec: parentRefs:
charts/osdu-developer-auth/templates/http-route.yaml:9
- For consistency and clarity, please reformat the 'spec' block so that 'parentRefs:' is on its own indented line under 'spec:'. This will improve readability of the HTTPRoute definition.
spec: parentRefs:
This pull request introduces significant updates to the Helm charts for Istio and OSDU services, transitioning from Istio's native configuration to Gateway API for improved infrastructure management and flexibility. Key changes include updating DNS and certificate provisioning processes, enabling Gateway API support for HTTPRoute and ReferenceGrant resources, and removing legacy VirtualService configurations.
Transition to Gateway API:
DNS and Certificate Provisioning Updates:
charts/istio-certs/README.mdto reflect the use of Gateway API gateways for DNS labels and Let's Encrypt certificate provisioning.charts/istio-certs/values.yamlto replaceistioServiceNamewithgatewayServiceNameand updated associated namespace parameters.charts/istio-certs/templates/configmap.yamlwith Gateway API-specific configurations for DNS annotations and HTTP-01 challenge routing. [1] [2]Gateway API Resource Integration:
gatewaysandhttproutesincharts/istio-certs/templates/access_control.yaml.charts/istio-ingress/templates/gateways.yamlto use Gateway API'sGatewayresource, replacing Istio's native configuration.charts/osdu-developer-auth/templates/http-route.yamlandcharts/osdu-developer-service/templates/http-route.yaml. [1] [2]Removal of Legacy Istio Configurations:
charts/osdu-developer-auth/templates/virtual-service.yamlandcharts/osdu-developer-service/templates/virtual-service.yaml) in favor of Gateway API's HTTPRoute resources. [1] [2]Improved Namespace Dependency Handling:
charts/istio-ingress/templates/referencegrants.yaml.These changes streamline the configuration process, enhance compatibility with Gateway API, and improve scalability for OSDU services.