Skip to content

openapi-diff: fixed issue reported by CodeQL #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Jun 20, 2025

Issue link:
https://codeql.microsoft.com/issues/b36e4a94-e9b8-42d4-b881-60533c236314?copilot_promptid=E91B0CE9-0C1B-4AC2-8A46-33F49B67E058

Summary

  • Use shell-quote to escape the input string when constructing the autorest command
  • Added tests

@raych1 raych1 self-assigned this Jun 20, 2025
@raych1 raych1 requested a review from weshaggard June 20, 2025 15:51
@raych1
Copy link
Member Author

raych1 commented Jun 20, 2025

@weshaggard could you review the new commits which fixed the issue on windows?

@raych1 raych1 moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🔨🏗️💻🚧 Jun 23, 2025
@raych1 raych1 merged commit 41c3493 into main Jun 23, 2025
7 checks passed
@raych1 raych1 deleted the user/raych1/fix-codeql-issue branch June 23, 2025 16:44
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🔨🏗️💻🚧 Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants