Source map

[sergey-shandar]

This PR has several major changes

1. A new class ParsedJson, which has

• a typed JSON (JSON which is deserialized into specific type),
• a JToken (raw deserialized JSON which has line, position information)
• a file name.

2. ObjectPath is a sequence of functions which can generate a name of next child property. Because old and new swagger documents may have different paths to the same item (e.g. parameter), we use a function instead of a constant.
3. ObjectPath functions can resolve '$ref'.

New output

{
  "id": "1039",
  "code": "AddedOperation",
  "message": "The new version is adding an operation that was not found in the old version.",
  "jsonref-old": "old/added_path.json#/paths/~1api~1Operations/post",
  "jsonpath-old": null,
  "location-old": "",
  "jsonref-new": "new/added_path.json#/paths/~1api~1Operations/post",
  "jsonpath-new": "paths./api/Operations.post",
  "location-new": "new\\added_path.json:31:15",
  "type": "Info",
  "docurl": "https://github.com/Azure/openapi-diff/tree/master/docs/rules/1039.md",
  "mode": "Addition"
}

[vladbarosan]

@sergey-shandar can you describe your changes a little please ? that would be of great help for the reviewers

[veronicagg]

Comments inline. Thanks!

[veronicagg]

Updates look good to me, could you add a test to check on location updates you're making? thanks!

[sergey-shandar]

@veronicagg I will add it as soon as I get confirmation about format of location from @sarangan12.

[sarangan12]

1. Code changes to add jsonPath to output
2. Future: Add length of the word with issue

[sarangan12]

Please fix the ci failure before merge

[veronicagg]

LGTM, thx!