Url as a source #112
Closed
Url as a source #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumik81
commented
Apr 11, 2018
lumik81
commented
- Extended solution to be able to handle Url as a source
- Fixed: the SwaggerParameter may be null
* Fixed: the SwaggerParameter may be null
vladbarosan
suggested changes
May 11, 2018
|
|
||
| private bool ValidateUri(Uri uri) | ||
| { | ||
| if (Instance.OldSpec.Scheme == Uri.UriSchemeFile && |
There was a problem hiding this comment.
why arent you comparing the parameter and instead the Instance.OldSpec
| return true; | ||
| } | ||
|
|
||
| if (Instance.OldSpec.Scheme == Uri.UriSchemeHttp || Instance.OldSpec.Scheme == Uri.UriSchemeHttps) |
|
|
||
| if (Instance.OldSpec.Scheme == Uri.UriSchemeHttp || Instance.OldSpec.Scheme == Uri.UriSchemeHttps) | ||
| { | ||
| // todo: validate the uri |
There was a problem hiding this comment.
wouldn't a call to this do a basic validation ? https://msdn.microsoft.com/en-us/library/system.uri.iswellformeduristring(v=vs.110).aspx
|
|
||
| if (uri.Scheme == Uri.UriSchemeFile) | ||
| { | ||
| return File.ReadAllText(uri.AbsolutePath); |
There was a problem hiding this comment.
can you please provide a Gist where this has been run successfully so we make sure there is no regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.