Re-implement iteration for paging.Paged #22
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 88.52% 88.78% +0.25%
==========================================
Files 10 10
Lines 1229 1239 +10
==========================================
+ Hits 1088 1100 +12
+ Misses 141 139 -2
Continue to review full report at Codecov.
|
| self.next_link = "" | ||
| self.current_page = [] | ||
| self._current_page_iter_index = 0 | ||
| self._derserializer = Deserializer(classes) |
There was a problem hiding this comment.
Could you take this opputunity to fix the typo in the "deRserializer" attribute? :)
msrest/paging.py
Outdated
| self.reset() | ||
| self.next_link = url | ||
| return self.next() | ||
| return list(self) |
There was a problem hiding this comment.
This will not work if there is a page3. Current code will return page 2 + page 3. Yes, I miss this unittest... :(
There was a problem hiding this comment.
Why wouldn't it work? This is simply exhausting the iterator so if a "page 3" would have come through the iterator then this will as well.
And are you adding a test for this?
There was a problem hiding this comment.
Fixed in the latest commit.
3 participants
No description provided.