Repository navigation
phase2(post): a2a-gateway Dockerfile must COPY tests/ workspace members - #128
Merged
Merged
Conversation
a2a-gateway/Dockerfile uses per-member Cargo.toml + src copies (rather than the workspace-wide style of controller/inference-router); after S16 + S17 added tests/chaos and tests/cncf-conformance to the workspace members list, cargo refuses to load /work/Cargo.toml without their manifests. Add the two tests/* Cargo.toml + src copies before the cargo-build invocation. Mirrors the fix already shipped to the other two Rust image Dockerfiles in 23a6614. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…r}/benches The benches directories are referenced from each crate's Cargo.toml as [[bench]] entries; cargo refuses to parse the workspace manifest if the named bench files don't exist in the build context. controller/Dockerfile and inference-router/Dockerfile copy the whole crate dir so they are fine; a2a-gateway/Dockerfile takes the per-subdir slice approach and needs the benches/ dirs added explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
Pal Lakatos-Toth (pallakatos)
added a commit
that referenced
this pull request
May 12, 2026
phase2(post): a2a-gateway Dockerfile must COPY tests/ workspace members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge follow-up to PR #125. The a2a-gateway image build (which runs against
main) failed because a2a-gateway/Dockerfile uses per-member Cargo.toml + src copies (rather than the workspace-wide style of controller/inference-router); after S16 + S17 addedtests/chaosandtests/cncf-conformanceto the workspace members list, cargo refuses to load/work/Cargo.tomlwithout their manifests.Fix: add the two
tests/*Cargo.toml + src copies before the cargo-build invocation. Mirrors the fix already shipped to the other two Rust image Dockerfiles in 23a6614.No code-behavior change.