Fix iotedge restart command with workload sockets (#6891) #6898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `iotedge restart` command so that it sends a stop request followed by a start request. This is necessary so that workload sockets are properly notified of the restart.
Comment on lines
-149
to
-152
| async fn start(&self, _id: &str) -> anyhow::Result<()> { | ||
| unimplemented!() | ||
| } | ||
| async fn stop(&self, _id: &str, _wait_before_kill: Option<Duration>) -> anyhow::Result<()> { |
There was a problem hiding this comment.
So, we are saying restart is now unimplemented?
There was a problem hiding this comment.
No, they are now implemented. Restart is the one that is now unimplemented.
There was a problem hiding this comment.
or is this just internal?
damonbarry
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
iotedge restartcommand so that it sends a stop request followed by a start request. This is necessary so that workload sockets are properly notified of the restart.