-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iotedge restart command with workload sockets (#6891) #6898
Conversation
Fix the `iotedge restart` command so that it sends a stop request followed by a start request. This is necessary so that workload sockets are properly notified of the restart.
async fn start(&self, _id: &str) -> anyhow::Result<()> { | ||
unimplemented!() | ||
} | ||
async fn stop(&self, _id: &str, _wait_before_kill: Option<Duration>) -> anyhow::Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we are saying restart is now unimplemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they are now implemented. Restart is the one that is now unimplemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is this just internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Varun says he talked to Gordon about the changes and believes they're ready to merge.
Fix the
iotedge restart
command so that it sends a stop request followed by a start request. This is necessary so that workload sockets are properly notified of the restart.