Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Upgrade to latest Rust version #6501

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Conversation

onalante-msft
Copy link
Contributor

This is our monthly toolchain upgrade to the latest stable version. Since iotedge/edgelet is a binary package, we want to be tracking Rust compiler releases closely in the event a stdlib vulnerability is found. We do not pin to "stable", however, since that has caused pipeline breakage when some code patterns are made illegal (like in the upgrade from 1.47 to 1.48 1) or, more often, clippy lints are added.

  • Use $crate metavariable in macros referencing crate
  • Remove let () = ..
  • Fix build failure in edgehub-proxy

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Footnotes

  1. https://github.com/rust-lang/rust/blob/master/RELEASES.md#compatibility-notes-11
    Namely, the point on mem::uninitialized.

- Remove `let () = ..`
- Fix build failure in edgehub-proxy
@kodiakhq kodiakhq bot merged commit 9a5ebdd into Azure:main Jul 12, 2022
@onalante-msft onalante-msft deleted the rust-upgrade branch July 12, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants