Fixed exception type in BrokerConnection::SendAsync, #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l be retried if no mqttclient exists
| @@ -166,7 +168,7 @@ public async Task DisconnectAsync() | |||
|
|
|||
| public async Task<bool> SendAsync(string topic, byte[] payload, bool retain = false) | |||
| { | |||
| var client = this.mqttClient.Expect(() => new Exception("No mqtt-bridge connector instance found to send messages.")); | |||
| var client = this.mqttClient.Expect(() => new IOException("No mqtt-bridge connector instance found to send messages.")); | |||
There was a problem hiding this comment.
IOException is typically used for file I/O.. so it seems a little odd here. Can we use a custom exception here?
varunpuranik
approved these changes
Jun 14, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Jun 28, 2021
so operation will be retried if no mqttclient exists. The problem occurred when EdgeHub was shutting down but a message was being sent upstream. As the protocol head was stopped, that cleared the mqttclient client, so the send operation in SendAsync() threw an 'Exception' instance, which was not retriable by CloudEndpoint, so it just skipped the message.
ggjjj
pushed a commit
to ggjjj/iotedge
that referenced
this pull request
Jul 22, 2021
so operation will be retried if no mqttclient exists. The problem occurred when EdgeHub was shutting down but a message was being sent upstream. As the protocol head was stopped, that cleared the mqttclient client, so the send operation in SendAsync() threw an 'Exception' instance, which was not retriable by CloudEndpoint, so it just skipped the message.
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
so operation will be retried if no mqttclient exists. The problem occurred when EdgeHub was shutting down but a message was being sent upstream. As the protocol head was stopped, that cleared the mqttclient client, so the send operation in SendAsync() threw an 'Exception' instance, which was not retriable by CloudEndpoint, so it just skipped the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so operation will be retried if no mqttclient exists.
The problem occurred when EdgeHub was shutting down but a message was being sent upstream. As the protocol head was stopped, that cleared the mqttclient client, so the send operation in SendAsync() threw an 'Exception' instance, which was not retriable by CloudEndpoint, so it just skipped the message.