-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Timestamps
Option via mgmt.sock
#4970
Introduce Timestamps
Option via mgmt.sock
#4970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something that is auto-generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iotedge/edgelet/api/managementVersion_2020_07_07.yaml
Lines 282 to 303 in 6c4269a
parameters: | |
- $ref: '#/parameters/api-version' | |
- in: path | |
name: name | |
description: The name of the module to obtain logs for. (urlencoded) | |
required: true | |
type: string | |
- in: query | |
name: follow | |
description: Return the logs as a stream. | |
type: boolean | |
default: false | |
- in: query | |
name: tail | |
description: Only return this number of lines from the end of the logs. | |
type: string | |
default: "all" | |
- in: query | |
name: since | |
description: Only return logs since this time, as a duration (1 day, 1d, 90m, 2 days 3 hours 2 minutes), rfc3339 timestamp, or UNIX timestamp. | |
type: string | |
default: "0" |
@gordonwang0 FYI for tokio update since this has mgmt api changes |
- Allow Management socket to accept `timestamps` option to be pass through docker socket API. - Update the documents for the latest API version - The latest API is being manually added since there is a gigantic out-of-sync between the template interface `managementVersion_2020_07_07.yaml` and `/edgelet/management` generated code.
…#4981) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires #4970
- Allow Management socket to accept `timestamps` option to be pass through docker socket API. - Update the documents for the latest API version - The latest API is being manually added since there is a gigantic out-of-sync between the template interface `managementVersion_2020_07_07.yaml` and `/edgelet/management` generated code.
…Azure#4981) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
…4981) (#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires #4970
- Allow Management socket to accept `timestamps` option to be pass through docker socket API. - Update the documents for the latest API version - The latest API is being manually added since there is a gigantic out-of-sync between the template interface `managementVersion_2020_07_07.yaml` and `/edgelet/management` generated code.
…zure#4981) (Azure#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
- Allow Management socket to accept `timestamps` option to be pass through docker socket API. - Update the documents for the latest API version - The latest API is being manually added since there is a gigantic out-of-sync between the template interface `managementVersion_2020_07_07.yaml` and `/edgelet/management` generated code.
…zure#4981) (Azure#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
- Allow Management socket to accept `timestamps` option to be pass through docker socket API. - Update the documents for the latest API version - The latest API is being manually added since there is a gigantic out-of-sync between the template interface `managementVersion_2020_07_07.yaml` and `/edgelet/management` generated code.
…zure#4981) (Azure#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
- Allow Management socket to accept `timestamps` option to be pass through docker socket API. - Update the documents for the latest API version - The latest API is being manually added since there is a gigantic out-of-sync between the template interface `managementVersion_2020_07_07.yaml` and `/edgelet/management` generated code.
timestamps
option to be pass through docker socket API.managementVersion_2020_07_07.yaml
and/edgelet/management
generated code.