fix: in case of error, propagate back error code of edgeHub #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanzebra
reviewed
May 3, 2021
| @@ -306,13 +307,33 @@ void HandleDirectMethodCall(string id, string method, string rid, byte[] payload | |||
| { | |||
| // TODO acquire the response timeout from the message | |||
| var callingTask = this.edgeHub.InvokeMethodAsync(rid, new DirectMethodRequest(id, method, payload, TimeSpan.FromMinutes(1))); | |||
| callingTask.ContinueWith( | |||
| async response => | |||
| _ = callingTask.ContinueWith( | |||
There was a problem hiding this comment.
Are there any tests we need to update?
nyanzebra
previously approved these changes
Jun 3, 2021
nyanzebra
approved these changes
Jun 3, 2021
and-rewsmith
pushed a commit
to and-rewsmith/iotedge
that referenced
this pull request
Jun 22, 2021
instead of using 0 (which is a result of uninitialized status property)
and-rewsmith
added a commit
that referenced
this pull request
Jun 22, 2021
ggjjj
pushed a commit
to ggjjj/iotedge
that referenced
this pull request
Jul 22, 2021
instead of using 0 (which is a result of uninitialized status property)
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
instead of using 0 (which is a result of uninitialized status property)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using 0 (which is a result of uninitialized status property)