Fix Edge CA and module cert CSRs to use version 0 (v1) instead of non-existent version 2 (v3). #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2 (v3). v3 is correct for certificates (`X509`) but not for CSRs (`X509Req`).
|
Could you double-check edgeHub is cool with this change by running E2E tests manually? Thanks. |
|
Why? Edge Hub is not affected by this change. |
arsing
changed the title
|
Okay, I see the problem. certd is copying the CSR version into the cert version. That's bogus. I'll fix that first. |
gordonwang0
approved these changes
Apr 27, 2021
ggjjj
pushed a commit
to ggjjj/iotedge
that referenced
this pull request
Jul 22, 2021
…-existent version 2 (v3). (Azure#4904) v3 is correct for certificates (`X509`) but not for CSRs (`X509Req`).
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
…-existent version 2 (v3). (Azure#4904) v3 is correct for certificates (`X509`) but not for CSRs (`X509Req`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3 is correct for certificates (
X509) but not for CSRs (X509Req).