Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base image update script to not include generic-mqtt-tester base image. #4827

Merged
merged 2 commits into from
Apr 10, 2021
Merged

Update base image update script to not include generic-mqtt-tester base image. #4827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ec063
Update script to exclude the generic-mqtt-tester base image
yophilav Apr 10, 2021
0ff186d
typo
yophilav Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/BaseImageUpdate/baseImage.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function Update-ARM-BaseImages
Setup-BaseImage-Script

# Get all the Dockerfile file location
$fileLocale = $(Get-ChildItem -Recurse -Filter "Dockerfile" )
$fileLocale = $(Get-ChildItem -Recurse -Filter "Dockerfile" | Where {$_.FullName -notlike "*generic-mqtt-tester*"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to future proof it further you can introduce a collection of excluded names. I am fine with this though.


# Replace the underlying ASP .Net Core to the new version
# Assuming the ARM64 & ARM32 both use the same *-bionic-arm* ASP .Net Core image tag
Expand Down