Fix: throw transient error when edgeHubCore is disconnected from the broker #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…broker, so messages will be resent instead of dropping them
ancaantochi
reviewed
Mar 17, 2021
| @@ -121,6 +122,43 @@ void Spy(RpcPacket packet) | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task WhenNoConnectionMessagesDontGetDropped() | |||
There was a problem hiding this comment.
I think the test should just check that it throws IotHubException when it is disconnected.
There should be an integration test in CloudEndpointTest to check that the message is not dropped.
ancaantochi
approved these changes
Mar 17, 2021
vipeller
added a commit
to vipeller/iotedge
that referenced
this pull request
Mar 23, 2021
…broker (Azure#4603) so messages will be resent instead of dropping them (cherry picked from commit b196a15)
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
…broker (Azure#4603) so messages will be resent instead of dropping them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so messages will be resent instead of dropping them