Fix: CloudConnection did not forward close() call to cloud proxy #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadim-kovalyov
previously approved these changes
Mar 4, 2021
...b/core/src/Microsoft.Azure.Devices.Edge.Hub.MqttBrokerAdapter/upstream/BrokeredCloudProxy.cs
Outdated
Show resolved
Hide resolved
varunpuranik
reviewed
Mar 4, 2021
|
|
||
| try | ||
| { | ||
| result = await this.CloudProxy.Match( |
There was a problem hiding this comment.
Nit: suggest: .Map().GetOrElse(true)
varunpuranik
reviewed
Mar 4, 2021
|
|
||
| try | ||
| { | ||
| result = await this.CloudProxy.Match( |
varunpuranik
reviewed
Mar 4, 2021
|
|
||
| public class BrokeredCloudConnection : ICloudConnection | ||
| { | ||
| IIdentity identity; | ||
|
|
||
| public BrokeredCloudConnection(BrokeredCloudProxy cloudProxy) |
There was a problem hiding this comment.
Why is this not a ICloudProxy? We should avoid passing in actual types.. if possible.
varunpuranik
reviewed
Mar 4, 2021
| this.IsActive = true; | ||
| this.CloudProxy = Option.Some(cloudProxy as ICloudProxy); | ||
| this.identity = cloudProxy.Identity; |
There was a problem hiding this comment.
This seems odd... can we just pass in the Identity separately, like we do for CloudConnection?
nyanzebra
reviewed
Mar 4, 2021
vipeller
changed the title
- BrokeredCloudConnection now relies on underlying CloudProxy for active status instead of maintaining itself
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
…re#4546) The main change is in BrokeredCloudConnection.cs where it did not forward the call to CloudProxy. The rest of the change is only about to being able to log the Identity in case of failure. The removed "TODO" about the subscription is not needed anymore as the proper place was in ConnectionHander.cs/RemoveConnectionAsync() to remove existing subscriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is in BrokeredCloudConnection.cs where it did not forward the call to CloudProxy. The rest of the change is only about to being able to log the Identity in case of failure.
The removed "TODO" about the subscription is not needed anymore as the proper place was in ConnectionHander.cs/RemoveConnectionAsync() to remove existing subscriptions.