E2E test for connection events #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanzebra
reviewed
Feb 17, 2021
...hub/core/test/Microsoft.Azure.Devices.Edge.Hub.MqttBrokerAdapter.Test/ConnectionEventTest.cs
Outdated
Show resolved
Hide resolved
nyanzebra
reviewed
Feb 17, 2021
...hub/core/test/Microsoft.Azure.Devices.Edge.Hub.MqttBrokerAdapter.Test/ConnectionEventTest.cs
Outdated
Show resolved
Hide resolved
nyanzebra
approved these changes
Feb 22, 2021
vadim-kovalyov
approved these changes
Feb 22, 2021
|
|
||
| // This class is the one that is supposed to forward the MQTT messages to the broker. | ||
| // Now instead it swallows the messages, and auto-acks the RPC calls going upstream. | ||
| internal class NullBrokerConnector : IMqttBrokerConnector |
There was a problem hiding this comment.
seems like a good candidate to be moved to a separate file
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 23, 2021
huguesBouvier
pushed a commit
to huguesBouvier/iotedge
that referenced
this pull request
Feb 24, 2021
huguesBouvier
added a commit
that referenced
this pull request
Feb 24, 2021
and-rewsmith
pushed a commit
to and-rewsmith/iotedge
that referenced
this pull request
Feb 26, 2021
Co-authored-by: vipeller <51135538+vipeller@users.noreply.github.com>
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
Co-authored-by: vipeller <51135538+vipeller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.