Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.8: Adding Experimental feature flags for the new experimental features #1459

Merged
merged 5 commits into from
Jul 22, 2019

Conversation

varunpuranik
Copy link
Contributor

@varunpuranik varunpuranik commented Jul 19, 2019

Adding experimentalFeature* flags to the new experimental features. To enable a feature, you need to also enable Experimental features.

For example, to enable UploadLogs, you would set the following env vars -
experimentalFeatures__enabled=true
experimentalFeatures__enableUploadLogs=true

@myagley
Copy link
Contributor

myagley commented Jul 19, 2019

I'm nervous about the double underscore in the env var. Is it possible to make it one underscore?

@varunpuranik
Copy link
Contributor Author

I'm nervous about the double underscore in the env var. Is it possible to make it one underscore?

This was done deliberately - everything inside experimentalFeatures__* is inside the experimentalFeatures "section" in the configuration. In the App.config file, it would look something like this -

{
    "experimentalFeatures": {
        "enabled": true,
        "enableUploadLogs": true
    },
}

(sorry for the unfortunate capitalization, but I am just trying to be consistent here. Maybe we should change

@varunpuranik varunpuranik merged commit 9e6ea0c into Azure:release/1.0.8 Jul 22, 2019
@varunpuranik varunpuranik deleted the expft1 branch July 22, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants