-
Notifications
You must be signed in to change notification settings - Fork 459
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update
GetModuleLogs
method when tail + since + until
options are…
… provided. (#4975) (cherry-picked from 2b650a8) TL;DR - This PR chances the behavior of `GetModuleLogs` method to better facilitate the portal experience. Previous, when the `GetModuleLogs` is triggered from the azure portal with `tail + since + until`, all the 3 options are passed to Docker API management to fetch the log. The Docker API does the following: 1. Fetch the log of the module 2. Apply `tail` to the log 3. Apply the `since` and `until` to the log This results in an empty log most of the time which is not a desirable behavior. This PR changes the `GetModuleLogs` when the `tail + since + until` are specified together by doing the following: 1. Fetch Docker API with `since + until` log option 2. `tail` the returning log using LogProcessor (post-Akka). This allows a customer to get a tail of log within a given time frame. Note: This PR doesn't change the behavior of any other option combinations (i.e. `tail + since`, `tail`, `since`, etc). These combination are still managed by Docker API. Note2: I set RequestHandle timeout to be 30s instead of 600s by default
- Loading branch information
Showing
4 changed files
with
21 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters