Skip to content

Conversation

@bastbu
Copy link
Collaborator

@bastbu bastbu commented Oct 15, 2021

PR for issue #545

What is being addressed

A test did not clean up the environment variable that it set during the test setup. This PR does not ensure that there is no interference between this and other tests that are running in parallel.

@codecov-commenter
Copy link

Codecov Report

Merging #546 (570b5db) into dev (580ec7b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #546      +/-   ##
==========================================
+ Coverage   62.14%   62.15%   +0.01%     
==========================================
  Files         132      132              
  Lines        5547     5546       -1     
==========================================
  Hits         3447     3447              
+ Misses       2100     2099       -1     
Impacted Files Coverage Δ
...n.NetworkServer/ServiceFacadeHttpClientProvider.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580ec7b...570b5db. Read the comment docs.

@spygi spygi self-requested a review October 18, 2021 07:20
@bastbu bastbu merged commit de4422d into dev Oct 19, 2021
@bastbu bastbu deleted the bug/545-clean-up-environment branch October 19, 2021 05:56
@bastbu bastbu linked an issue Oct 19, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigurationTest does not clean up environment variables

4 participants