-
Notifications
You must be signed in to change notification settings - Fork 28
Adding IoT Edge Module support for Pnp Bridge #40
Conversation
/cc @olivierbloch |
|
||
extern PNP_ADAPTER SerialPnpInterface; | ||
extern PNP_ADAPTER ModbusPnpInterface; | ||
extern PNP_ADAPTER MqttPnpInterface; | ||
extern PNP_ADAPTER EnvironmentSensorInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnvironmentSensorInterface [](start = 19, length = 26)
Please add a comment or rename to reflect this is a sample virtual sensor for illustrative purposes #Resolved
@@ -92,12 +92,14 @@ typedef int SOCKET; | |||
HANDLE hDevice; | |||
LOCK_HANDLE hConnectionLock; | |||
IOTHUB_DEVICE_CLIENT_HANDLE DeviceClient; | |||
IOTHUB_MODULE_CLIENT_HANDLE ModuleClient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be a union. #Resolved
@@ -92,12 +92,14 @@ typedef int SOCKET; | |||
HANDLE hDevice; | |||
LOCK_HANDLE hConnectionLock; | |||
IOTHUB_DEVICE_CLIENT_HANDLE DeviceClient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeviceClient [](start = 36, length = 12)
Since the adapters are re-compiled for edge module support already, and the edge/device client APIs are mostly the same, another option to consider is define a custom type for the connection handle along with macros for IoTHub<Device|Module>Client_Foo. That way the adapter code will be a little easier to read without as many runtime forks. #Resolved
…evice/module bifurcation in adapters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work. Okay to merge, just a heads-up that the MSDocs sample will need to be updated shortly to reflect the moving of the Environmental sensor sample to the main bridge project. I'll work on this.
Adding Pnp Bridge Edge Module support:
Validatation: