Reuse senders #571
Merged
Reuse senders #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to support TLS renegotiation types inadvertently removed sharing transports, leading to a growing number of goroutines for workloads that create a lot of different clients. Create senders per TLS renegotiation type. Each sender is created on demand and cached for reuse.
|
Fixes #554 |
|
I've been wondering for this and previous changes...should the changelog be updated? |
|
Good question. Given that we no longer have monolithic releases I've been placing the changelog notes in each module's release notes. |
|
Maybe we should make a note of that for people who look to the changelog? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to support TLS renegotiation types inadvertently removed
sharing transports, leading to a growing number of goroutines for
workloads that create a lot of different clients.
Create senders per TLS renegotiation type. Each sender is created on
demand and cached for reuse.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:
devbranch, except in the case of urgent bug fixes warranting their own release.master, I've updated CHANGELOG.md to address the changes I'm making.