autorest: remove testing.T.Fatal() from test goroutine #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cifying a resource instead of a base url. This enables resource like KeyVault and Container Registry to use an authorizer configured from a configuration file.
* Using the timeout from the context if available - Makes PollingDuration optional * Renaming the registration start time * Making PollingDuration not a pointer * fixing a broken reference
…n for the currently logged in user, for local development scenarios. (Azure#316)
Added IsHTTPStatus() and HasHTTPStatus() methods to autorest.Response
* New Preparer: WithBytes * New Responder: `ByUnmarshallingBytes` * Reusing the bytes, rather than copying them * Fixing the broken test / switching to read the bytes directly
RFC specifies Retry-After header can be integer value expressing seconds or an HTTP-Date indicating when to try again. Removed superfluous check for HTTP status code.
* Add support for multi-tenant authentication Support for multi-tenant via x-ms-authorization-auxiliary header has been added for client credentials with secret scenario; this basically bundles multiple OAuthConfig and ServicePrincipalToken types into corresponding MultiTenant* types along with a new authorizer that adds the primary and auxiliary token headers to the reqest. The authenticaion helpers have been updated to support this scenario; if environment var AZURE_AUXILIARY_TENANT_IDS is set with a semicolon delimited list of tenants the multi-tenant codepath will kick in to create the appropriate authorizer. * feedback
* Support custom SendDecorator chains via context Added `autorest.WithSendDecorators` and `autorest.GetSendDecorators` for adding and retrieving a custom chain of SendDecorators to the provided context. Added `autorest.DoRetryForStatusCodesWithCap` and `autorest.DelayForBackoffWithCap` to enforce an upper bound on the duration between retries. Fixed up some code comments. * small refactor based on PR feedback * remove some changes for dev branch
* v12.3.0 (Azure#418) * Deserialize additionalInfo in ARM error * Allow a new authorizer to be created from a configuration file by specifying a resource instead of a base url. This enables resource like KeyVault and Container Registry to use an authorizer configured from a configuration file. * [WIP] Using the Context from the timeout if provided (Azure#315) * Using the timeout from the context if available - Makes PollingDuration optional * Renaming the registration start time * Making PollingDuration not a pointer * fixing a broken reference * Add NewAuthorizerFromCli method which uses Azure CLI to obtain a token for the currently logged in user, for local development scenarios. (Azure#316) * Adding User assigned identity support for the MSIConfig authorizor (Azure#332) * Adding ByteSlicePtr (Azure#399) * Adding a new `WithXML` method (Azure#402) * Add HTTP status code response helpers (Azure#403) Added IsHTTPStatus() and HasHTTPStatus() methods to autorest.Response * adding a new preparer for `MERGE` used in the Storage API's (Azure#406) * New Preparer/Responder for `Unmarshalling Bytes` (Azure#407) * New Preparer: WithBytes * New Responder: `ByUnmarshallingBytes` * Reusing the bytes, rather than copying them * Fixing the broken test / switching to read the bytes directly * Support HTTP-Date in Retry-After header (Azure#410) RFC specifies Retry-After header can be integer value expressing seconds or an HTTP-Date indicating when to try again. Removed superfluous check for HTTP status code. * Add support for multi-tenant authentication (Azure#412) * Add support for multi-tenant authentication Support for multi-tenant via x-ms-authorization-auxiliary header has been added for client credentials with secret scenario; this basically bundles multiple OAuthConfig and ServicePrincipalToken types into corresponding MultiTenant* types along with a new authorizer that adds the primary and auxiliary token headers to the reqest. The authenticaion helpers have been updated to support this scenario; if environment var AZURE_AUXILIARY_TENANT_IDS is set with a semicolon delimited list of tenants the multi-tenant codepath will kick in to create the appropriate authorizer. * feedback * rename Options to OAuthOptions (Azure#415) * Support custom SendDecorator chains via context (Azure#417) * Support custom SendDecorator chains via context Added `autorest.WithSendDecorators` and `autorest.GetSendDecorators` for adding and retrieving a custom chain of SendDecorators to the provided context. Added `autorest.DoRetryForStatusCodesWithCap` and `autorest.DelayForBackoffWithCap` to enforce an upper bound on the duration between retries. Fixed up some code comments. * small refactor based on PR feedback * remove some changes for dev branch * v12.3.0 * add yaml file for azure devops CI (Azure#419) * add status badge for azure devops CI (Azure#420) * enable build and test on linux (Azure#421) * enable build and test on linux * fail on first error and use portable std* * update test to run on devops * Refactor azure devops pipeline (Azure#422) Break monolithic script into separate scripts with useful names. Moved formatting checks to the end with succeededOrFailed conditions. * remove travis artifacts (Azure#423) * remove unnecessary trigger section from devops (Azure#424)
…E is not set before falling back on ~/.azure/ (Azure#471)
* support for parsing error messages from xml responses * fixing the linting * removed some duplicate code * fix bug introduced in refactoring * added XML test and fixed bug it uncovered
* Authorizers for Blob, File, Queue and Table Storage * Adding a SharedKey authorizer * refactor based on existing storage implementation * add missing storage emulator account name * replace hard-coded strings with constants * changed to by-ref
* Adding a new Authorizer for SAS Token Authentication
This commit introduces a new Authorizer for authenticating with
Blob Storage using a SAS Token
```
$ go test -v ./autorest/ -run="TestSas"
=== RUN TestSasNewSasAuthorizerEmptyToken
--- PASS: TestSasNewSasAuthorizerEmptyToken (0.00s)
=== RUN TestSasNewSasAuthorizerEmptyTokenWithWhitespace
--- PASS: TestSasNewSasAuthorizerEmptyTokenWithWhitespace (0.00s)
=== RUN TestSasNewSasAuthorizerValidToken
--- PASS: TestSasNewSasAuthorizerValidToken (0.00s)
=== RUN TestSasAuthorizerRequest
--- PASS: TestSasAuthorizerRequest (0.00s)
authorization_sas_test.go:76: [DEBUG] Testing Case "empty querystring without a prefix"..
authorization_sas_test.go:76: [DEBUG] Testing Case "empty querystring with a prefix"..
authorization_sas_test.go:76: [DEBUG] Testing Case "existing querystring without a prefix"..
authorization_sas_test.go:76: [DEBUG] Testing Case "existing querystring with a prefix"..
PASS
ok github.com/Azure/go-autorest/autorest 0.011s
```
* minor clean-up
* token: support for a custom refresh func * pass closures by value * minor clean-up
* autorest: fix dropped errror * autorest/adal: fix dropped test error
The retry helpers and a few other methods weren't reading and closing response bodies leading to connection leaks.
* Enable exponential back-off when retrying on 429 * enforce a 2-minute cap on delays if there isn't one * updated comment * fix type-o
* feat: extract token creation to public method for MSI auth * Add getter for token provider on BearerAuthorizer
* Fix Go module ambiguous import errors This is an extension of the mitigations introduced in Azure#455. Unfortunately, the original mitigations didn't address the primary cause of ambiguous import errors: the github.com/Azure/go-autorest module. The issue stems from the fact that old versions of the root module (github.com/Azure/go-autorest) provide the same packages as the newer submodules. To correct this situation, the _root module_ needs to be upgraded to a version that no longer provides those packages (a version where the submodules are present). Fortunately, the submodules can be leveraged to provide the necessary version bump. See: Azure#414 (comment) ---- Caveat: in order for this to work, an importable version of the root package needs to be referenceable. PR Azure#527 makes the root package importable. The go.mod files assume that this importable version will be referenceable as v14.2.0. If the version where the importable package is available ends up being different, these files will need to be updated. See also: Azure#395, Azure#413, Azure#414, Azure#455, Azure#481, Azure#524 * Update go.sum files Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
See from Azurre China portal - this is now cloudapp.chinacloudapi.cn
jhendrixMSFT
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
TestDoRetryForStatusCodes_Race()to not firet.Fatal()inside a goroutine.t.Fatal()is a convenience function that callst.Log()andt.FailNow().t.FailNow()should not be called from inside a goroutine. From the godoc:This race condition test only runs twice, as-is. Should I up the number of runs to something like
50? At that number the test still completes in 0.02s.