Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing rewrite #451

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Tracing rewrite #451

merged 1 commit into from
Aug 15, 2019

Conversation

jhendrixMSFT
Copy link
Member

The tracing package has been rewritten to provide a common interface for
wiring up the tracing package of choice; no tracing facility is provided
by default unless the opencensus package is imported. Please see the
CHANGELOG for more details.

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  • I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
  • If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

@jhendrixMSFT jhendrixMSFT self-assigned this Aug 15, 2019
@jhendrixMSFT
Copy link
Member Author

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhendrixMSFT Awesome thanks for this. LGTM

The tracing package has been rewritten to provide a common interface for
wiring up the tracing package of choice; no tracing facility is provided
by default unless the opencensus package is imported.  Please see the
CHANGELOG for more details.
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhendrixMSFT jhendrixMSFT merged commit 5e7a399 into Azure:master Aug 15, 2019
@jhendrixMSFT jhendrixMSFT deleted the tracingrewrite branch August 15, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants