Fix OpenCensus and OCAgent dependencies #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid depending on protobuf v1.3+ as it breaks kubernetes
|
This should resolve #413 |
There was a problem hiding this comment.
This is awesome. Thanks @jhendrixMSFT!
One comment on the override.
| version = "0.4.5" | ||
| version = "=0.3.0" | ||
|
|
||
| [[override]] |
There was a problem hiding this comment.
What's the plan for this override? Remove in a future version?
There was a problem hiding this comment.
Yes, once it's safe for kubernetes to ingest v1.3 of protobuf.
There was a problem hiding this comment.
Sounds good. Thanks again, @jhendrixMSFT!
vladbarosan
approved these changes
Aug 1, 2019
|
Awesome thanks @jhendrixMSFT. |
tamalsaha
added a commit
to gomodules/stow
that referenced
this pull request
Aug 1, 2019
xref: Azure/go-autorest#437 Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid depending on protobuf v1.3+ as it breaks kubernetes
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:
devbranch, except in the case of urgent bug fixes warranting their own release.master, I've updated CHANGELOG.md to address the changes I'm making.