Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom PrepareDecorator chains #436

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

jhendrixMSFT
Copy link
Member

Added functions for adding a retrieving one or more PrepareDecorators to
the provided context object. LRO polling will apply the preparers added
in this way.
WithSendDecorators will ignore empty slices of SendDecorators.

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  • I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
  • If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

Added functions for adding a retrieving one or more PrepareDecorators to
the provided context object.  LRO polling will apply the preparers added
in this way.
WithSendDecorators will ignore empty slices of SendDecorators.
@jhendrixMSFT jhendrixMSFT self-assigned this Jul 23, 2019
@jhendrixMSFT
Copy link
Member Author

This will be part of the fix for Azure/azure-sdk-for-go#1922, allowing custom preparers at call sites to add customer header values.

Copy link

@vladbarosan vladbarosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jhendrixMSFT jhendrixMSFT merged commit efe8ae7 into Azure:master Jul 30, 2019
@jhendrixMSFT jhendrixMSFT deleted the custompreparers branch July 30, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants