Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for TLS Renegotiation #383

Merged
merged 6 commits into from
Apr 17, 2019
Merged

add support for TLS Renegotiation #383

merged 6 commits into from
Apr 17, 2019

Conversation

tiraffe
Copy link
Contributor

@tiraffe tiraffe commented Apr 15, 2019 •
edited
Loading

Related to #384

@tiraffe tiraffe mentioned this pull request Apr 15, 2019
Closed
@tiraffe tiraffe changed the base branch from dev to master April 15, 2019 08:24
@tiraffe tiraffe closed this Apr 15, 2019
@tiraffe tiraffe reopened this Apr 15, 2019
jhendrixMSFT
jhendrixMSFT requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide more context on why this is needed, specifically which cognitive services APIs require this to be enabled? It's a bit surprising that after 2+ years of the SDK this is only showing up now.

@tiraffe
Copy link
Contributor Author

tiraffe commented Apr 16, 2019

Can you please provide more context on why this is needed, specifically which cognitive services APIs require this to be enabled? It's a bit surprising that after 2+ years of the SDK this is only showing up now.

Sure, I have sent you an email to provide more details.

@jhendrixMSFT jhendrixMSFT merged commit 7461c5d into Azure:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbarosan vladbarosan vladbarosan approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiraffe @jhendrixMSFT @vladbarosan