Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: fix proxy support for default sender (#379) #381

Merged
merged 1 commit into from
Apr 9, 2019
Merged

tracing: fix proxy support for default sender (#379) #381

merged 1 commit into from
Apr 9, 2019

Conversation

grrtrr
Copy link
Contributor

@grrtrr grrtrr commented Apr 1, 2019

This resolves #379 by using the defaults of http.DefaultTransport without modifying the global object.

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the CHANGELOG and version.go (v11.7.1)?

@grrtrr
Copy link
Contributor Author

grrtrr commented Apr 8, 2019

@jhendrixMSFT - yes, will update PR and force-push branch changes.

@jhendrixMSFT jhendrixMSFT merged commit d10011c into Azure:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing: default sender proxy support broken
2 participants