Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CosmosDb endpoint and fix ACR endpoints for Gov Clouds #377

Merged
merged 4 commits into from
Mar 25, 2019
Merged

Add CosmosDb endpoint and fix ACR endpoints for Gov Clouds #377

merged 4 commits into from
Mar 25, 2019

Conversation

vladbarosan
Copy link

  • fix DNS endpoint for ACR
  • Add Cosmos DB endpoint

Fixes #366

@jhendrixMSFT
Copy link
Member

Can you merge #376 into this PR?

@vladbarosan
Copy link
Author

@jhendrixMSFT it seems ACR is not present in the German Cloud . do we want to leave it blank ?

@vladbarosan vladbarosan mentioned this pull request Mar 25, 2019
Closed
4 tasks
@vladbarosan
Copy link
Author

Fixes #375

jhendrixMSFT
jhendrixMSFT approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment to add a note somewhere (perhaps a comment in the code) that there's no endpoint for German

@vladbarosan vladbarosan merged commit 8ac2172 into master Mar 25, 2019
@justaugustus justaugustus mentioned this pull request Apr 15, 2019
Merged
@jhendrixMSFT jhendrixMSFT deleted the addcosmosdbendpoint branch July 10, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose 'CosmosDBDNSSuffix' in the Environments struct
2 participants
@vladbarosan @jhendrixMSFT