Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add atm e2e tests #231

Merged
merged 1 commit into from
Dec 13, 2024
Merged

test: add atm e2e tests #231

merged 1 commit into from
Dec 13, 2024

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Dec 12, 2024

What type of PR is this?
/kind test

What this PR does / why we need it:
Add first negative e2e tests for ATM.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

https://github.com/Azure/fleet-networking/actions/runs/12296154911/job/34314583519 test passed

Special notes for your reviewer

@zhiying-lin zhiying-lin marked this pull request as draft December 12, 2024 09:11
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (c4356a7) to head (f5477bb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   79.76%   80.05%   +0.28%     
==========================================
  Files          27       27              
  Lines        3840     3840              
==========================================
+ Hits         3063     3074      +11     
+ Misses        621      611      -10     
+ Partials      156      155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiying-lin zhiying-lin force-pushed the set-e2e-env branch 4 times, most recently from a29e82e to f889339 Compare December 12, 2024 12:07
@zhiying-lin zhiying-lin marked this pull request as ready for review December 12, 2024 12:41
Copy link
Contributor

@jwtty jwtty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, lgtm. But I think we should also setup an Azure client and check the ATM Azure source status.

@zhiying-lin
Copy link
Contributor Author

In general, lgtm. But I think we should also setup an Azure client and check the ATM Azure source status.

Before, i was thinking of the e2e should not tightly depend on our implementation, eg, how to get this actual azure resource. But since the validation cannot be done in the integration test, i will add the azure validation in a separate PR in case of the regression.

@jwtty jwtty merged commit 8fd9033 into main Dec 13, 2024
16 checks passed
@jwtty jwtty deleted the set-e2e-env branch December 13, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants