Add RawInput to workaround double-serialization issue #966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address a conflicting need in Durable Functions extension. We want to use
TaskHubClient
from withinLocalGrpcListener
so that we leverage all the logic there, especially the distributed tracing work. However, our input is already serialized andTaskHubClient
would double serialize it. To work around this an "internal" API calledRawInput
has been added. When this type is used as the input forTaskHubClient
, we will directly useRawInput.Value
instead of serializing the input.RawInput
is "internal" in the sense that it ispublic
, but in an.Internal
namespace, with an[Obsolete]
attribute, and xmldoc advising customers to use the type at their own risk. This is a pattern used in a few .NET libraries (efcore, webjobs, functions worker, etc) to address the internal-yet-public functionality.