[WIP] feature/core-entities #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implementaton of entity mechanics, compatible with existing DF SDK, but without a user-facing entity SDK for DTFx * address PR feedback. * fix usings and namespaces * address PR feedback * address PR feedback (remove NameObjectManager), fix breaking change in TaskHubWorker, fix some comments * address PR feedback (fix CustomExceptionsTest, remove public property) * add #nullable enable to most new classes * address PR feedback * try to fix compiler errors * add a configuration setting that disables separate dispatch by default * address PR feedback * address PR feedback
sebastianburckhardt
added
core-entities
# Conflicts: # src/DurableTask.Core/TaskOrchestrationDispatcher.cs
* update scheduler state and entity status format and helpers * fix mess-up caused by merge conflict
* revise how event messages are represented and used * fix merge anomaly.
* rename OperationBatch to EntityBatch * fix accidentally commited change from another PR
* revise task entity definition * commit change that had been accidentally committed to a different PR. * Apply suggestions from code review Co-authored-by: David Justo <david.justo.1996@gmail.com> * Apply suggestions from code review Co-authored-by: Jacob Viau <javia@microsoft.com> --------- Co-authored-by: David Justo <david.justo.1996@gmail.com> Co-authored-by: Jacob Viau <javia@microsoft.com>
…#957) * revise entity backend properties and implement entity backend queries. * Minor revisions to querries and properties, and improved comments. * fix validation of which LockNext methods are being called. * improve comments * fix useage of IEntityOrchestrationService. * revise how to exclude entity results from queries. * address PR feedback
* fix propagation path for entity parameters that need to reach the orchestration executor. * address PR feedback.
* rename includeDeletedEntities to includeStatelessEntities and add comment explaining the meaning * add backlogQueueSize and lockedBy to entity metadata
* revise how entity messages are serialized when sent by orchestrators. * address PR feedback (use RawInput)
* rename includeStateless to includeTransient * rename variable also
jviau
approved these changes
Oct 17, 2023
| public async override Task<EntityMetadata?> GetEntityAsync( | ||
| EntityId id, | ||
| bool includeState = false, | ||
| bool includeStateless = false, |
There was a problem hiding this comment.
Think this should change to includeTransient before GA (and on the base class)
There was a problem hiding this comment.
oh right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch for the new entity support in DT.Core and DT.AzureStorage.