Skip to content

Removing annotate-namespace for fleet resources#544

Merged
davidgamero merged 3 commits intoAzure:mainfrom
audrastump:stumpaudra/fleet/annotation
Apr 21, 2025
Merged

Removing annotate-namespace for fleet resources#544
davidgamero merged 3 commits intoAzure:mainfrom
audrastump:stumpaudra/fleet/annotation

Conversation

@audrastump
Copy link
Member

@audrastump audrastump commented Apr 18, 2025

Description

Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.
For a Fleet workflow, the user doesn't necessarily have permissions to annotate the namespace. By default, we will turn this off for fleet resources in the workflow to fix this warning:
image

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@audrastump audrastump changed the title Removing annoate-namespace for fleet resources Removing annotate-namespace for fleet resources Apr 18, 2025
@nwnt
Copy link

nwnt commented Apr 18, 2025

LGTM

Copy link
Member

@bosesuneha bosesuneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit d1fb205 into Azure:main Apr 21, 2025
145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants