Skip to content

Add auth type for azure login in github workflow#502

Merged
bfoley13 merged 1 commit intomainfrom
brfole/azure_auth_support
Feb 20, 2025
Merged

Add auth type for azure login in github workflow#502
bfoley13 merged 1 commit intomainfrom
brfole/azure_auth_support

Conversation

@bfoley13
Copy link
Member

Description

This adds the ability to support MSI in github templates through adding auth-type into the azure/login action.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@bosesuneha bosesuneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bfoley13 bfoley13 enabled auto-merge (squash) February 19, 2025 22:59
@bfoley13 bfoley13 merged commit 3119b12 into main Feb 20, 2025
145 checks passed
@bfoley13 bfoley13 deleted the brfole/azure_auth_support branch February 20, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants