Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Portal UI Bug #226

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Fix Portal UI Bug #226

merged 4 commits into from
Jan 14, 2022

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Jan 13, 2022

Summary of the Pull Request

This PR fixes a bug in the Portal UI that is caused because of a change in the Portal UI Framework.

References

The current Portal UI reports that a UI Element cannot be loaded.

PR Checklist

Validation Steps Performed

See comments below.

@marvinbuss marvinbuss added the bug Something isn't working label Jan 13, 2022
@marvinbuss marvinbuss added this to the v1.3.0 milestone Jan 13, 2022
@marvinbuss marvinbuss self-assigned this Jan 13, 2022
@marvinbuss marvinbuss requested a review from a team as a code owner January 13, 2022 20:10
@marvinbuss marvinbuss linked an issue Jan 13, 2022 that may be closed by this pull request
1 task
@marvinbuss
Copy link
Collaborator Author

Preview Link

Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@esbran esbran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@marvinbuss marvinbuss merged commit f7fcb35 into main Jan 14, 2022
@marvinbuss marvinbuss deleted the marvinbuss/fix_ui branch January 14, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Portal UI is broken
2 participants