Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Region Availability #221

Merged
merged 8 commits into from
Dec 23, 2021
Merged

Improving Region Availability #221

merged 8 commits into from
Dec 23, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Dec 17, 2021 •
edited
Loading

This PR fixes
Improving Region Availability for DMA by including the list of regions where ZRS is available. Also removed unnecessary dependency based on linting rules. This will fix: Azure/data-management-zone#256

@marvinbuss marvinbuss added the enhancement New feature or request label Dec 17, 2021
@marvinbuss marvinbuss self-assigned this Dec 17, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner December 17, 2021 08:21
@marvinbuss marvinbuss added this to the v1.3.0 milestone Dec 17, 2021
marvinbuss
marvinbuss commented Dec 17, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Dec 17, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Dec 17, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Preview Link

amanjeetsingh
amanjeetsingh reviewed Dec 19, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed minor changes to verbiage around support and coverage. Thanks.

marvinbuss
marvinbuss commented Dec 20, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esbran esbran self-requested a review December 23, 2021 16:05
esbran
esbran previously approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@esbran esbran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@esbran esbran self-requested a review December 23, 2021 16:40
esbran
esbran approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@esbran esbran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry Christmas

@marvinbuss marvinbuss merged commit 8f02dfe into main Dec 23, 2021
@marvinbuss marvinbuss deleted the marvinbuss/location_improvements branch December 23, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esbran esbran esbran approved these changes

@amanjeetsingh amanjeetsingh Awaiting requested review from amanjeetsingh

Assignees

@marvinbuss marvinbuss

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

DMA Set up in Central India
3 participants
@marvinbuss @amanjeetsingh @esbran