-
Notifications
You must be signed in to change notification settings - Fork 57
dark mode for header in DE #2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@sakshigupta12feb please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Preview this branch
Problem TBD: When the Data Explorer iframe reloads (e.g., after changing database account or any value that triggers reload), the iframe loses its theme state and defaults to light mode. The header keeps its dark mode state but doesn't sync it back to the iframe.
Tried solution:
Added logic in HostedExplorer.tsx to:
Listen for the "ready" message that the iframe sends when it finishes loading
When the iframe is ready, send the current theme state from the header to the iframe
DEdarkmodeHeader.mp4
](url)