Fixed Index Advisor #2270
Open
Fixed Index Advisor #2270
+1,071
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reset states fixes * fixed sdk response --------- Co-authored-by: nishthaAhujaa <nishtha17354@iiittd.ac.in>
This reverts commit a3a2bf2.
nishthaAhujaa
force-pushed
the
refresh-ar
branch
from
b9e62d0 to
1f54577
Compare
Collaborator
|
Please add a description explaining changes of the PR. |
Collaborator
|
Do we have playwright test(s) for Index Advisor ? If not, please add some. |
Collaborator
Author
#2292 was working on a different branch, as this was the fix for the revert PR. If you want me to add in the same one, will do. Thanks! @jawelton74 |
Co-authored-by: nishthaAhujaa <nishtha17354@iiittd.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview this branch
Revert PR fix: #2177
Error: Id is undefined for shared throughput accounts
state.indexingPolicies[this.collection.id()],
Fix : Moved the index advisor logic inside the isCollectionSettingsTab block as it was breaking for Shared Throughput Accounts
& Added optional chaining (?) state.indexingPolicies[this.collection?.id()]
Playwright
playwrightIndexAdvisor.mp4