Skip to content

ESLint9 fix for packages/calling-stateful-client #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 17, 2025

Conversation

prabhjot-msft
Copy link
Contributor

What

ESLint9 fix for packages/calling-stateful-client

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/4158989

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6802521 6802521 ➖ unchanged 0
398.bundle.js 12413574 12413574 ➖ unchanged 0
399.bundle.js 362421 362421 ➖ unchanged 0
450.bundle.js 4471 4471 ➖ unchanged 0
82.bundle.js 28319 28319 ➖ unchanged 0
91.bundle.js 4071 4071 ➖ unchanged 0

Total change: +0 B ➖

Copy link
Contributor

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 5827276 5827276 ➖ unchanged 0
398.bundle.js 12413560 12413560 ➖ unchanged 0

Total change: +0 B ➖

Copy link
Contributor

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1779453 1779453 ➖ unchanged 0
110.bundle.js 365689 365689 ➖ unchanged 0
450.bundle.js 4455 4455 ➖ unchanged 0
82.bundle.js 28303 28303 ➖ unchanged 0
91.bundle.js 4055 4055 ➖ unchanged 0

Total change: +0 B ➖

@prabhjot-msft prabhjot-msft enabled auto-merge (squash) June 17, 2025 20:20
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58359 / 94855
61.52%
58359 / 94855
61.52%
1187 / 2716
43.7%
3386 / 5772
58.66%
Current 58383 / 94877
61.53%
58383 / 94877
61.53%
1187 / 2716
43.7%
3431 / 5797
59.18%
Diff 24 / 22
0.01%
24 / 22
0.01%
0 / 0
0%
45 / 25
0.52%

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29611 / 47246
62.67%
29611 / 47246
62.67%
816 / 1492
54.69%
2421 / 3854
62.81%
Current 29591 / 47283
62.58%
29591 / 47283
62.58%
816 / 1492
54.69%
2428 / 3850
63.06%
Diff -20 / 37
-0.09%
-20 / 37
-0.09%
0 / 0
0%
7 / -4
0.25%

@prabhjot-msft prabhjot-msft merged commit 56eec6f into main Jun 17, 2025
40 checks passed
@prabhjot-msft prabhjot-msft deleted the prabhjot/eslint9-fix branch June 17, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants