Announce base image change in README.md #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoChilia
requested review from
Jacekey23,
bebound,
dbradish-microsoft,
dcaro,
jiasli and
yonzhan
bebound
approved these changes
Sep 3, 2024
Member
|
PR title can be
|
MoChilia
changed the title
jiasli
reviewed
Sep 3, 2024
Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
yonzhan
approved these changes
Sep 3, 2024
jiasli
approved these changes
Sep 3, 2024
dcaro
reviewed
Sep 4, 2024
README.md
Outdated
| # GitHub Action for Azure CLI | ||
|
|
||
| > [!WARNING] | ||
| > The base image of Azure CLI's docker image is switched to Azure Linux since version `2.64.0`. The `az` commands will remain unaffected. To ensure a smooth transition, please migrate Alpine-specific commands to Azure Linux commands in azure/cli action. For more information, see https://go.microsoft.com/fwlink/?linkid=2282203. |
Collaborator
There was a problem hiding this comment.
Suggested change
| > The base image of Azure CLI's docker image is switched to Azure Linux since version `2.64.0`. The `az` commands will remain unaffected. To ensure a smooth transition, please migrate Alpine-specific commands to Azure Linux commands in azure/cli action. For more information, see https://go.microsoft.com/fwlink/?linkid=2282203. | |
| > Starting with Azure CLI version `2.64.0`, the Azure CLI docker image will be based of Azure Linux. The `az` commands are not affected by this change. To ensure the compatibility of your pipelines, please migrate Alpine-specific commands to Azure Linux commands in the scripts used in the azure/cli action. | |
| For more information, see https://go.microsoft.com/fwlink/?linkid=2282203. |
Member
There was a problem hiding this comment.
I don't think "based of" is correct English: https://www.merriam-webster.com/grammar/based-on-vs-based-off. It should be "based off", but "based on" seems more common.
Member
Author
|
@dcaro, I've modified the announcement according to your suggestion. Please review it again. Thank you. |
jiasli
requested changes
Sep 4, 2024
Member
jiasli
left a comment
jiasli
left a comment
There was a problem hiding this comment.
Please reconsider the wording.
jiasli
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.