Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Intents aren't captured when IntentDialog approach isn't used #11

Open

Description

There are multiple ways to start a dialog based on the intent retrieved by a recognizer. Not everyone is using the IntentDialog in their bots. At the moment botbuilder-instrumentation only captures the intent while using an Intent Dialog.

I am not sure (yet) how those events can be captured in a better way. Hooking in on LuisRecognizer.recognize should work, however it would be nice if all recognizers are supported. Maybe the intent should be captured and sent to Application Insights on the creation / initialisation of a new dialog.

bot.dialog('/', [
    (session: Session) => {
        session.endDialog('message');
    }
]).triggerAction({
    matches: 'default'
});

vs

const dialog = new builder.IntentDialog({ recognizers: [recognizer] });
bot.dialog('/', dialog);

dialog.matches('default', [
    function (session, args, next) {
        session.endDialog('message');
    }
]);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions