Skip to content

Conversation

@andyleejordan
Copy link
Contributor

@andyleejordan andyleejordan commented Oct 28, 2025

So check if that's the scope, and if so, emit it and the type, instead of the formatted name.

I tested that this reverts to the necessary behavior for DSC's expectations by using "moduleExtensionConfigs": true.

Microsoft Reviewers: Open in CodeFlow

So check if that's the scope, and if so, emit it and the type,
instead of the formatted name.
}

if (metadata.IsAzResource ||
Context.SemanticModel.TargetScope == ResourceScope.DesiredStateConfiguration ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to start a test file similar to https://github.com/Azure/bicep/blob/main/src/Bicep.Core.IntegrationTests/Extensibility/RadiusCompatibilityTests.cs (which was initially created to make sure we maintain compatibility with Radius - to make sure that we don't regress this in future.

Happy to merge this change without it as it's ultimately an experimental feature, but just be aware that you do run the risk of getting accidentally broken again if you don't have a way to assert compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And done 😄

@anthony-c-martin anthony-c-martin merged commit eb45f4e into Azure:main Oct 29, 2025
41 of 42 checks passed
@github-actions
Copy link
Contributor

Test this change out locally with the following install scripts (Action run 18924778841)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 18924778841
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 18924778841"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 18924778841
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 18924778841"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants