Skip to content

Remove moduleIdentity experimental feature#17909

Merged
anthony-c-martin merged 2 commits into
mainfrom
ant/identity
Aug 29, 2025
Merged

Remove moduleIdentity experimental feature#17909
anthony-c-martin merged 2 commits into
mainfrom
ant/identity

Conversation

@anthony-c-martin
Copy link
Copy Markdown
Member

@anthony-c-martin anthony-c-martin commented Aug 28, 2025

Description

Remove moduleIdentity experimental feature

Example Usage

module mod './module.bicep' = {
  identity: {
    type: 'UserAssigned'
    userAssignedIdentities: {
      '${mid.id}': {}
    }
  }
}

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 28, 2025

Test this change out locally with the following install scripts (Action run 17329580669)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 17329580669
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 17329580669"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 17329580669
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 17329580669"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 28, 2025

Dotnet Test Results

    90 files   -     44      90 suites   - 44   37m 48s ⏱️ - 39m 40s
12 309 tests  -     14  12 309 ✅  -     12  0 💤 ±0  0 ❌  - 2 
28 363 runs   - 14 178  28 363 ✅  - 14 176  0 💤 ±0  0 ❌  - 2 

Results for commit e1f3b86. ± Comparison against base commit e8cfc1f.

This pull request removes 1942 and adds 670 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�ӽ\u000e�0\u0010\u0007��>E�\u0003�\u0016z�������\u0000\u0015Έ\u0011$�	���-�q���ab�c�^����޴[4)V5\u000b�VkF��-%e�yGؚ\u0008�8�!(E\u0008mG��ǽnLeG��\u001f��4Y���K��/�fQ |
+[J\u0006JB��4�8+Rl٥�\u0015]w>н�\u001b�a�\u001f�nK���\u0003��� \u0003	\u0000�p\u0005���ϒ�?���z�\u0002�\u0012�\u0006�\u001d�G��
=�k�ϥgs\u001c�q��\u0002l\u0001n\u001c\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ
�0\u0010\u0000��>E�\u0003�I�\u001f#t\u0010\u001c�H\u0015\u0004W	6`�Vi+\u0014|y�A\Z\�#�oȐ;�]�\u0005�{]��NLQ�@)�#�7l	�Z�\u001b�I@�\u001b\u0006XrI\u0000�ux��.l)c����\u001c�*�LH$\u0017lN\u0019VH*���3\u001b;wň�w]]�4OL���-oҳ����t:|�o�+�6��2@8�,`�s\u0002�hV\u0000G��?���\u0017���6Z�6�]�-������q\u001c�\u0019�\u000b�yu�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ\u000e� \u0010\u0000`�>�O�w��\u000e�\u001d�
�5�O�F45i��šI\u0007M\u0017�M�7r\8�\u001c<��~[�C�x.�\���
\u0002����\u0000	\u0019�\u0017``H��I?{%#:��&���Y?Hd�mOUY���L(ȹ�BJ�mBl?\u0019��j�cѹ��o��}톄j*a�F����[-�4�\u0000�!\u0001)���_\u0000\u0006%��_d&�|�+��(���\u0004 TG*\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K
�0\u0010\u0006�=E�\u0001b�I���\u0008n<@lG��Z�
\u0005��\u000bq��\u000f�|���L\u0018~�޻f\u000b.��"BX�&hl����}�0i\u00103o\u0014Q��F\u00087�o��^ծlW�c�\u000f�\u0016�:� bFii9\u0013��PX+����C5\u0016����(�\u0013hȥ��]{6Ծ�7�\u0001��M7�[����)����q��V]7�%����\u0007\u000e\u000e94\u0005�5$;ȎP\u0006\u001b|r�
�K��y��M�\u0005\u0018���\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��M\u000b�0\u0018\u0007��\u0014�\u0007�{�\u000c<\u0004\u001d2��k�\u001cd��\u001a\u0008}��!�(]Ԃ�;�=\u000f�\u0019�?\u0018�t�2:5e\u0005)U$�`h�\u0012�u�0�\u0000�\u0017\u0004��\\u0000�5�O��^պ��Lq�\u000f"��u��\u0008K.�"�"(�¡b3[;��p��t}��"5
�Tעm��ڿ}M�����;�S�\u0011a\u0000s�\u0019e\u001c\u0013\u0002��K��I2�����qrXl��q��&�ܳ?�gr\u001c�q��\u0004?B�<\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003���
�0\u000c\u0007�}�=A��M���\u001e}��\u0003?X'�����v\u0007�Æ��	�wl\u0002I	���\�-ܡ�\u001b�TF�\u0014s��h=�>@m\u0004�\u0017\u0010`�Y���}�\u0011]Ӻ:��Ĭ\u001fD6q��,r�ltF�@Z�̨M(��J�\]{�;�����sS�����_��є�\u000b~kƧ�\u0003�@\u0006�J3\u0012��#ِ�E2����?�� ��(Z�\u0013��k!\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.DirectResourceCollectionTests ‑ DirectResourceCollectionAccess_NotAllowedWithinLoops ("output loopOutput array = [for i in range(0, 2): {
  prop: map(containerWorkers, (w) => w.properties.ipAddress.ip)
}]")
Bicep.Core.IntegrationTests.DirectResourceCollectionTests ‑ DirectResourceCollectionAccess_NotAllowedWithinLoops ("resource propertyLoop 'Microsoft.ContainerInstance/containerGroups@2022-09-01' = {
  name: 'gh9440-loop'
  location: 'westus'
  properties: {
    containers: [for i in range(0, 2): {
      name: 'gh9440-w1c-${i}'
      properties: {
        command: [
          'echo "${join(map(containerWorkers, (w) => w.properties.ipAddress.ip), ',')}"'
        ]
      }
    }]
  }
}")
Bicep.Core.IntegrationTests.DirectResourceCollectionTests ‑ DirectResourceCollectionAccess_NotAllowedWithinLoops ("var loopVar = [for i in range(0, 2): {
  prop: map(containerWorkers, (w) => w.properties.ipAddress.ip)
}]")
Bicep.Core.IntegrationTests.Emit.ParamsFileWriterTests ‑ Params_file_with_no_errors_should_compile_correctly ("
using 'main.bicep'

// involves all syntax
param myParam = {
  arr: [
    {
      a : 'b'
    }
    {
      c : true
    }
  ]
  name: 'complex object!'
  priority: 3
  val: null
  obj: {
      a: 'b'
      c: [
          'd'
           1
      ]
  }
}","
{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
  "contentVersion": "1.0.0.0",
  "parameters": {
    "myParam": {
      "value": {
        "arr" : [
          {
            "a" : "b"
          },
          {
            "c" : true
          }
        ],
        "name" : "complex object!",
        "priority" : 3,
        "val" : null,
        "obj" : {
          "a" : "b",
          "c" : [
            "d",
            1
          ]
        }
      }
    }
  }
}","
param myParam object
")
…

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin merged commit d991dfe into main Aug 29, 2025
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/identity branch August 29, 2025 16:51
@mumian
Copy link
Copy Markdown
Contributor

mumian commented Sep 16, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants