Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Changes to moduleIndex.json generation for AVM module renames #602

Merged
merged 3 commits into from
Nov 10, 2023
Merged

ci: Changes to moduleIndex.json generation for AVM module renames #602

merged 3 commits into from
Nov 10, 2023

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Nov 6, 2023

Description

This PR makes changes to the generate-module-index-data.js file to cope with the AVM module renames.

⚠️Please do not merge this PR until the renames are complete (we will notify when this is done - cc: @AlexanderSehr & @eriqua )⚠️ @shenglol this is now ready to review, approve and merge 👍

@shenglol please take a look. Note that AVM Pattern modules will now have a module group path, as per AVM specs:

@jtracey93 jtracey93 added the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready or aligned to future direction etc. label Nov 6, 2023
@jtracey93 jtracey93 changed the title Changes to moduleIndex.json generation for AVM module renames ci: Changes to moduleIndex.json generation for AVM module renames Nov 6, 2023
@jtracey93 jtracey93 closed this Nov 6, 2023
@jtracey93 jtracey93 reopened this Nov 6, 2023
@AlexanderSehr AlexanderSehr added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 7, 2023
@jtracey93 jtracey93 added CI Type: Hygiene 🧹 things related to testing, issue triage etc. and removed Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready or aligned to future direction etc. labels Nov 10, 2023
@jtracey93 jtracey93 marked this pull request as ready for review November 10, 2023 14:49
@jtracey93 jtracey93 requested review from a team as code owners November 10, 2023 14:49
@jtracey93 jtracey93 requested a review from shenglol November 10, 2023 14:50
@shenglol shenglol merged commit 344730d into Azure:main Nov 10, 2023
@jtracey93 jtracey93 deleted the users/jtracey93/update-brm-index-for-avm-rename branch November 10, 2023 18:21
segraef pushed a commit to segraef/bicep-registry-modules that referenced this pull request Nov 17, 2023
…zure#602)

## Description

This PR makes changes to the `generate-module-index-data.js` file to
cope with the AVM module renames.

~~**⚠️Please do not merge this PR until the renames are complete (we
will notify when this is done - cc: @AlexanderSehr & @eriqua )⚠️**~~
@shenglol this is now ready to review, approve and merge 👍

@shenglol please take a look. Note that AVM Pattern modules will now
have a module group path, as per AVM specs:

- [Resource Module
Naming](https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-rmnfr1---category-naming---module-naming)
- [Pattern Module
Naming](https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-pmnfr1---category-naming---module-naming)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Hygiene 🧹 things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants