Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Istio add-on in AKS #3584

Merged
merged 20 commits into from
Nov 4, 2024
Merged

feat: support Istio add-on in AKS #3584

merged 20 commits into from
Nov 4, 2024

Conversation

fsforza
Copy link
Contributor

@fsforza fsforza commented Oct 16, 2024

Description

This Pull Request enable Istio add-on on AKS. Following features are enabled:

  • Istio Revisions Selection
  • Internal Ingress Gateway
  • External Ingress Gateway
  • Plug your own CA from Key Vault

Closes #3363

Pipeline Reference

Pipeline
avm.res.container-service.managed-cluster

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@fsforza fsforza requested review from a team as code owners October 16, 2024 18:59
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 16, 2024
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 16, 2024
@fsforza fsforza changed the title Support Istio add-on in AKS feat: support Istio add-on in AKS Oct 16, 2024
@fsforza
Copy link
Contributor Author

fsforza commented Oct 16, 2024

@microsoft-github-policy-service agree

package-lock.json Outdated Show resolved Hide resolved
@eriqua eriqua marked this pull request as draft October 19, 2024 11:44
@eriqua eriqua removed the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 19, 2024
@eriqua eriqua marked this pull request as ready for review October 19, 2024 11:44
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 19, 2024
@eriqua
Copy link
Contributor

eriqua commented Oct 19, 2024

Thanks a lot @fsforza for quickly addressing the above comments!
The scope of the change is now at module level, therefore the module owner can take the review further.
@ilhaan @JPEasier FYI

@eriqua
Copy link
Contributor

eriqua commented Nov 2, 2024

Hey @ilhaan, @JPEasier just a heads up to have a look at this PR when you have some availability. Thanks!

Copy link
Contributor

@JPEasier JPEasier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!
Thank you for your contribution @fsforza 🚀

@JPEasier JPEasier merged commit 2ee2acf into Azure:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Support Istio Service Mesh add-on in AKS
3 participants