Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new module for app configuration #352

Merged
merged 5 commits into from
May 8, 2023
Merged

feat: new module for app configuration #352

merged 5 commits into from
May 8, 2023

Conversation

sunilthorat09
Copy link
Contributor

@sunilthorat09 sunilthorat09 commented Apr 28, 2023

Description

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.

Enable GitHub Worksflows in your fork to enable auto-generation of assets with our GitHub Action.
To trigger GitHub Actions after auto-generation, add a GitHub PAT as a secret in your forked repository called PAT.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

  • This is a bug fix:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.
  • I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:
    • The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
    • The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • The PR contains breaking changes, and I have bumped the MAJOR version in version.json.
  • I have updated the examples in README with the latest module version number.

Closes #334

@sunilthorat09
Copy link
Contributor Author

@dciborow @shenglol Can you please register 'Microsoft.AppConfiguration' resource provider on the Test subscription(edf507a2-6235-46c5-b560-fd463ba2e771). Test failure logs.

@shenglol
Copy link
Contributor

Microsoft.AppConfiguration

Done.

@shenglol
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sunilthorat09
Copy link
Contributor Author

sunilthorat09 commented May 4, 2023

@dciborow @shenglol Can you please help to onboard this new module manifest to MCR and also help to review the code. Thanks!.

@shenglol
Copy link
Contributor

shenglol commented May 5, 2023

Will merge this once the MCR manifest PR is merged.

@shenglol shenglol merged commit 03b317a into Azure:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: Azure App Configuration
3 participants