-
Notifications
You must be signed in to change notification settings - Fork 168
[feat]: verl patches for vllm 13 compatibility #4713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yeshsurya
wants to merge
11
commits into
main
Choose a base branch
from
yeshwanth/torch_and_dep_upgrade_in_environment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+224
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for assets-test0 tests 0 ✅ 0s ⏱️ Results for commit 58fcdf3. ♻️ This comment has been updated with latest results. |
a52f490 to
2aba2e3
Compare
928a52b to
58fcdf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the vLLM-based rollout server infrastructure, focusing on better LoRA (Low-Rank Adaptation) support, compatibility with newer vLLM versions, enhanced IPv6 handling, and improved modularity. The main updates include introducing a custom LoRA request and hijack logic, updating dependencies, refactoring the vLLM server class hierarchy, and ensuring compatibility with vLLM 0.13.0+ and Ray 2.53.0.
Key changes:
LoRA (Low-Rank Adaptation) Support and vLLM Integration
utils.pymodule with a customTensorLoRARequestandVLLMHijackclass to allow loading LoRA adapters directly from tensors, overcoming vLLM's limitation of only supporting file-based LoRA adapters. This enables more flexible and efficient LoRA synchronization between actor models.enable_lora,max_loras,max_lora_rank) based on the model configuration. [1] [2]Compatibility and Dependency Updates
requirements.txtfor improved compatibility and performance.flash-attnfor CUDA 12.6 compatibility.pickletocloudpicklefor serialization invllm_async_server, improving compatibility with complex Python objects.vLLM Server Refactor and API Adjustments
vLLMHttpServerBase) and a Ray-remote subclass (vLLMHttpServer), improving code modularity and clarity.RolloutConfig(notRewardModelConfig) is accepted in the vLLM HTTP server. [1] [2] [3]FlexibleArgumentParserandget_tcp_uriimports).IPv6 and Networking Improvements
Miscellaneous Enhancements
Futureobjects for compatibility with vLLM 0.13.0+. [1] [2]These changes collectively improve the flexibility, maintainability, and compatibility of the rollout server infrastructure with the latest vLLM and Ray versions, while enabling advanced LoRA workflows.