Keep compatibility with Go 1.13.14. #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on older go versions.
|
|
mohsha-msft
approved these changes
Mar 16, 2021
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mohsha-msft Updated the changes to not return the error when the request id is missing (as err was not expected by the tests). How can I run the tests locally? |
|
@semk , Thanks for reaching out and I appreciate your contribution. Most of the test cases will work with just the first two ( Reach out for more help :) |
siminsavani-msft
approved these changes
Mar 17, 2021
siminsavani-msft
added a commit
that referenced
this pull request
Jul 2, 2021
* Removed requestId, Timeout, versionId, snapshot from the function signature of GetTags() and SetTags() (#252) * Changed the function signature of getTags and setTags * Minor Adjustment * Review - 1 * Adding Support for PutBlobFromUrl (#251) * Regenerate SDK * Regenerate SDK with proper version * Adding support for PutBlobFromURL * Correcting regen code and handling other errors * Resolving comments on PR * Correcting SetTags method * Updating tests with GetTags and SetTags * Remove swagger/Go_BlobStorage/code-model-v1 * Checks value of metadata & reorganized tests Co-authored-by: Adele Reed <adreed@microsoft.com> * Keep compatibility with Go 1.13.14. (#264) * - Keep compliance with Golang 1.13.14. http.Header has no method Values on older go versions. * Do not return error when client request id is missing * Adding MSI Login Example (#241) * Added MSI login example * Minor edits Co-authored-by: zezha-msft <zezha@microsoft.com> * Offer Knob to Disable Syslog | Default logging to syslog enabled (#268) * Provide Knob For Syslog * Reverting changes to GetTags/SetTags & BlobPropertiesInternal (#269) * Adding MSI Login Example (#241) * Added MSI login example * Minor edits Co-authored-by: zezha-msft <zezha@microsoft.com> * Reverting changes to GetTags/SetTags & BlobPropertiesInternal Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Co-authored-by: zezha-msft <zezha@microsoft.com> Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com> Co-authored-by: zezha-msft <zezha@microsoft.com> * Update go dependencies * Resolving Concurrency Issues (#275) * Resolving concurrency issues * Fixing concurrency test * Minor changes * Incremented version and added to changelog * Updated version to 0.14 Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Co-authored-by: Adele Reed <adreed@microsoft.com> Co-authored-by: Sreejith Kesavan <sreejithemk@gmail.com> Co-authored-by: zezha-msft <zezha@microsoft.com> Co-authored-by: Yang Peng <42422145+yangp18@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.Headerhas no methodValueson older go versions. azblob 0.13 broke the compatibility with Go 1.13.