Filter out Exclude Paths for PR Pipelines#9649
Merged
JimSuplizio merged 2 commits intoAzure:mainfrom Jan 16, 2025
Merged
Conversation
Collaborator
|
The following pipelines have been queued for testing: |
scbedd
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
weshaggard
reviewed
Jan 16, 2025
weshaggard
reviewed
Jan 16, 2025
weshaggard
reviewed
Jan 16, 2025
weshaggard
reviewed
Jan 16, 2025
benbp
reviewed
Jan 16, 2025
eng/common/pipelines/templates/steps/save-package-properties.yml
Outdated
Show resolved
Hide resolved
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Jan 16, 2025
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jan 16, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9649 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com>
swathipil
pushed a commit
to swathipil/azure-sdk-tools
that referenced
this pull request
Feb 4, 2025
* Filter out Excludes for PR Pipelines * Updates for feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@scbedd and @weshaggard
These are the common changes required to filter out PackageInfo generation by what should be excluded from the pull request pipelines. This is the example in Python, which excludes
sdk/cosmos. The unfortunate thing here is that we can't access the pr->paths->exclude meaning this needs to be duplicated. Because of the default in the save-package-properties.yml nothing will break if the ExcludePaths aren't plumbed through. The only downside here is that wildcards aren't accepted but then again, most excludes in yml files aren't wildcarded.I'd created a draft PR in Python to test these changes. Notice that the PR had changes in Cosmos and Template. This is the test run and if you notice, Cosmos no longer has a PackageInfo file in the artifacts and it's no longer running tests for azure-cosmos in the pullrequest pipeline. The diff.json for the PR is below which correctly has ExcludePaths.
Last but not least, the test PR in Python also shows where ExcludePaths would have to be plumbed through. Once this gets reviewed and pushed out to the repositories, I'll end up making those changes in Python. For Java, we'll have more excludes, mostly for Track1 libraries, Cosmos, resourcemanagerhybrid and possibly Spring.
Fixes #9634