Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typespec renaming #5691

Merged
5 commits merged into from
Mar 16, 2023
Merged

typespec renaming #5691

5 commits merged into from
Mar 16, 2023

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Mar 13, 2023

  • renaming cadl to typespec

@chunyu3 chunyu3 requested a review from m-nash March 13, 2023 08:54
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member

benbp commented Mar 14, 2023 •
edited
Loading

The convention that I have seen is either TypeSpec when capitalized, or typespec when lowercased. So anywhere you are using Typespec I think that should be changed to TypeSpec.

@chunyu3
Copy link
Member Author

chunyu3 commented Mar 15, 2023

The convention that I have seen is either TypeSpec when capitalized, or typespec when lowercased. So anywhere you are using Typespec I think that should be changed to TypeSpec.

Thanks @benbp I updated.

@chunyu3 chunyu3 requested a review from weshaggard March 15, 2023 02:49
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Mar 15, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we are doing this side-by-side with the cadl files until we can convert everything I'm good with this change. Lets make sure we have a tracking issue to clean these up once things are converted.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Mar 16, 2023
Merged
Merged
chunyu3 added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 16, 2023
@azure-sdk @chunyu3
Sync eng/common directory with azure-sdk-tools for PR 5691 (#25257)
8db9e10 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#5691 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: FAREAST\chunyu <chunyu@microsoft.com>
@ghost
Copy link

ghost commented Mar 16, 2023

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f25c0d0 into main Mar 16, 2023
@ghost ghost deleted the yc/typespecRenaming branch March 16, 2023 03:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder left review comments

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

@m-nash m-nash Awaiting requested review from m-nash

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chunyu3 @azure-sdk @benbp @weshaggard @mikeharder @iscai-msft